-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data table manager): fix data table manager scroll issue #2852
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f1ad728 The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR is missing a Jira ticket reference in the title or description. |
🥷 Code experts: no user matched threshold 10 Rhotimee has most 🧠 knowledge in the files. See details
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
@@ -55,7 +55,7 @@ const TableContainer = styled.div<TTableContainer>` | |||
|
|||
${(props) => | |||
// this is needed in order to have a sticky header | |||
props.maxHeight ? `overflow-x: auto;` : ''} | |||
props.maxHeight ? `overflow-x: auto;` : 'overflow-x: scroll;'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props.maxHeight ? `overflow-x: auto;` : 'overflow-x: scroll;'} | |
overflow-x: auto; |
In theory, auto
is solving the same problem as scroll
does, but in a more elegant way. Introducing scrollbars only when needed instead of having them visible at all times. This should be sufficient, if it is a scrolling-issue. Can you verify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, I realised and moved it back to wip. Thank you 🙏🏾
When there is a horizontally long table that requires scrolling,
The user should be able to horizontally scroll only the table container without any other element of view scrolling along.