Trim '[bot]' suffix from botIdentity #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashvarts
requested review from
a team,
hnnsgstfssn,
Freyert,
Oded-B,
yzdann and
jared-logan-patrick-ct
hnnsgstfssn
approved these changes
Nov 14, 2024
Oded-B
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Telefonistka wasn't minimizing its own previous comments. This is because the comment author and the commenter identity did not match. The commenter identity as returned by graphql had
[bot]appended to the name, while the comment author did not. This is fixed by trimming the[bot]suffix from the identity before comparing it to the comment author.tested: https://github.com/commercetools/k8s-manifests-poc/pull/327
Type of Change
Checklist