Sd 805 improve diff comment #32

Oded-B · 2024-10-23T11:45:04Z

Description

Avoid displaying the "Sync from PR Branch" checkbox for new applications and use native markdown "alerts".

Create a new function to check if all application in a PR are new.
Write tests for new function
Rename HasSyncableComponents to DisplaySyncBranchCheckBox to better match its new usage.
Switch from Emoji based annotation to GH markdown "alerts"

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

Checklist

I have read the contributing guidelines
Existing issues have been referenced (where applicable)
I have verified this change is not present in other open pull requests
Functionality is documented
All code style checks pass
New code contribution is covered by automated tests
All new and existing tests pass

…ons. match its new usage * Create a new function to check if all application in a PR are new. * Write tests for new function * Rename HasSyncableComponents to DisplaySyncBranchCheckBox to better

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

internal/pkg/githubapi/github.go

* The happy path is left-aligned * Break label rename * Function Doc format * Un-nest two if statement

…omment2

internal/pkg/githubapi/github.go

Just return true when a relevant app is found

Oded-B added 2 commits October 23, 2024 13:23

Avoid displaying the "Sync from PR Branch" checkbox for new applicati…

003166a

…ons. match its new usage * Create a new function to check if all application in a PR are new. * Write tests for new function * Rename HasSyncableComponents to DisplaySyncBranchCheckBox to better

Switch from Emoji based annotation to GH markdown "alerts"

16d146b

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

yzdann reviewed Oct 23, 2024

View reviewed changes