Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve application diffs #23

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Improve application diffs #23

merged 3 commits into from
Sep 5, 2024

Conversation

hnnsgstfssn
Copy link

No description provided.

@hnnsgstfssn hnnsgstfssn force-pushed the SD-407-diff-improvement branch 4 times, most recently from d1bf18d to 8e1b400 Compare September 4, 2024 08:42
@hnnsgstfssn hnnsgstfssn changed the title WIP diff changes Improve application diffs Sep 4, 2024
@hnnsgstfssn hnnsgstfssn marked this pull request as ready for review September 4, 2024 08:42
@hnnsgstfssn
Copy link
Author

Example in https://github.com/commercetools/k8s-manifests-poc/pull/224#issuecomment-2327442207

@hnnsgstfssn hnnsgstfssn force-pushed the SD-407-diff-improvement branch 2 times, most recently from 7f07243 to 1673d32 Compare September 4, 2024 09:06
yzdann
yzdann previously approved these changes Sep 5, 2024
View reviewed changes
Copy link

@yzdann yzdann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

I didn't try to understand diff functionality (as it's coming from golang) instead invested my time on understanding the test.

internal/pkg/argocd/diff/diff.go Show resolved Hide resolved
internal/pkg/argocd/argocd.go Outdated Show resolved Hide resolved
internal/pkg/argocd/argocd_test.go Show resolved Hide resolved
sunchill06
sunchill06 previously approved these changes Sep 5, 2024
View reviewed changes
ashvarts
ashvarts previously approved these changes Sep 5, 2024
View reviewed changes
yzdann
yzdann previously approved these changes Sep 5, 2024
View reviewed changes
@hnnsgstfssn
Improve application diff
2e21882 
This changes the application diff to render a YAML diff with a number of
context lines instead of relying on the cmp library previously used
which would render a diff of Go objects.
@hnnsgstfssn
Allow bare URL in markdown
30978db 
After discussion it has been deemed unnecessary to enforce non-bare URLs
in markdown.
@hnnsgstfssn
Upgrade golangci-lint
2bd03ff 
The earlier version fails to run on Darwin with Go 1.23.
@hnnsgstfssn hnnsgstfssn merged commit 4a14b34 into main Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzdann yzdann yzdann approved these changes

@sunchill06 sunchill06 sunchill06 left review comments

@ashvarts ashvarts ashvarts left review comments

@Freyert Freyert Awaiting requested review from Freyert Freyert was automatically assigned from commercetools/special-delivery

@Oded-B Oded-B Awaiting requested review from Oded-B Oded-B was automatically assigned from commercetools/special-delivery

@jared-logan-patrick-ct jared-logan-patrick-ct Awaiting requested review from jared-logan-patrick-ct jared-logan-patrick-ct was automatically assigned from commercetools/special-delivery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hnnsgstfssn @ashvarts @yzdann @sunchill06