Use subprocess in bas2prg #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a small change to the python script
tools/bas2prg.py, replacing the call toos.systemwithsubprocess.run.I was attempting to build the demos on my Windows machine (I've mostly used my mac with this project before) and was having issues with this line. I'm using MSys2 (and MinGW) for Makefile support, but
os.systemruns usingcmd.exe. The problem is thatcmd.exedoesn't handle forward slashes in paths, so the path specified in the Makefile causes problems. Switching tosubprocess.runavoids this issue by not calling any shell (sinceshell=False), letting the OS handle the forward slashes as it normally does. Making this change also has the advantage of better handling spaces in the path.I also went ahead and added a variable to the makefile to allow it to work when the emulator is located somewhere else. This can be utilized by calling make using
EMULATOR=/path/to/x16emu make.