Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos: use /tmp instead of /dev/shm #635

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

macos: use /tmp instead of /dev/shm #635

wants to merge 1 commit into from

Conversation

devtekve
Copy link

In macos a lot of the tests in OP still seem to rely on "/dev/shm" so this, alongside with commaai/openpilot#34097 should unblock those cases

@devtekve devtekve marked this pull request as ready for review November 24, 2024 12:08
@deanlee deanlee mentioned this pull request Nov 24, 2024
Open
adeebshihadeh
adeebshihadeh requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pull this out into a constant to reduce all the ifdef everywhere?

@adeebshihadeh adeebshihadeh marked this pull request as draft November 28, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devtekve @adeebshihadeh