What happens after I run the foo-1.0.pkg installer? I assume it puts the file on disk somewhere, but I couldn't find it

Overall the code looks reasonable I think. Some nits and some tweaks likely necessary to get it working reliably in CI and on my laptop.

One area that needs to be fleshed out is the english docs surrounding the examples. We should have a short explanation of what is going on, how these traits and the output files can be used from a user perspective, and with links to upstream documentation for more details

CC @lefou @alexarchambault

Managed to find the foo program in Applications after installing the .pkg, but running it seems to exit immediately before doing anything. Maybe we can make it pop up a Swing window or something just so it's visible to the user the program works?

As for the JpackageModule implementation, I decided to reuse most of the JpackageModule code @lefou linked to the original issue.

Please add me as co-author to the relevant git commit.

Co-authored-by: Tobias Roeser <[email protected]>

@lefou
As requested, I've added you as a co-author. Since there's only 1 commit so far, I amended my last commit.

Managed to find the foo program in Applications after installing the .pkg, but running it seems to exit immediately before doing anything. Maybe we can make it pop up a Swing window or something just so it's visible to the user the program works?

OK, I'll update the example code to be a basic desktop app in Swing.

One area that needs to be fleshed out is the english docs surrounding the examples. We should have a short explanation of what is going on, how these traits and the output files can be used from a user perspective, and with links to upstream documentation for more details

In the original issue description, I interpreted your mention of "/** Usage */ tests and textual explanations" as referring to adding illustrative examples inside build.mill, which I have done. Sounds like this is referring to updating the Mill documentation. Can you please point me to an example of what you have in mind?

@lihaoyi

What happens after I run the foo-1.0.pkg installer? I assume it puts the file on disk somewhere, but I couldn't find it

Managed to find the foo program in Applications after installing the .pkg, but running it seems to exit immediately before doing anything. Maybe we can make it pop up a Swing window or something just so it's visible to the user the program works?

Double-clicking or doing an open foo-1.0.pkg in Terminal should show the installer.

I've updated the jpackage example to show a Swing GUI when the app is launched either from a .dmg or .pkg (after installing it to /Applications).

For the app-image package, launching from the CLI (via ./out/foo/jpackageAppImage.dest/image/foo.app/Contents/MacOS/foo) should also show the Swing GUI.

@ayewo for an example of the inline docs for the example tests, see https://github.com/com-lihaoyi/mill/blob/main/example/scalalib/basic/3-multi-module/build.mill. Basically the examples should contain their own explanations in // line comments, and the entire example with code/doc-line-comments/usage-block-comments can get included wholesale in the documentation as a end-user-understandable page

@lihaoyi I’ve addressed all of your feedback.

Thanks, will take a look

Just looked through this, I think it looks pretty good.

Some last requests:

• Can you include your new examples into the documentation in https://github.com/com-lihaoyi/mill/blob/main/docs/modules/ROOT/pages/javalib/module-config.adoc?plain=1#L56-L58, and use ./mill docs.fastPages to check that it looks good to you

• I imagine a common use case would be to generate jpackage outputs for all platforms, which the current trait JpackageModule makes difficult. Let's make a def jpackageAppImage0 anonymous task that takes the jpackageType: String as a parameter, and then have jpackageAppImage/jpackageDmg/jpackagePkg/jpackageExe/jpackageMsi/jpackageRpm/jpackageDeb tasks that use jpackageAppImage0, and maybe a jpackageAll task that aggregates all the results. This should make it easier for the common use case where someone wants to generate all possible executable packages for the same Java module

@lihaoyi

Thanks for the feedback.

• I imagine a common use case would be to generate jpackage outputs for all platforms, which the current trait JpackageModule makes difficult. Let's make a def jpackageAppImage0 anonymous task that takes the jpackageType: String as a parameter, and then have jpackageAppImage/jpackageDmg/jpackagePkg/jpackageExe/jpackageMsi/jpackageRpm/jpackageDeb tasks that use jpackageAppImage0, and maybe a jpackageAll task that aggregates all the results. This should make it easier for the common use case where someone wants to generate all possible executable packages for the same Java module

Unfortunately, jpackage is not a cross-platform tool the way you imagine it.

From the docs:

It will be able to produce a native package in a platform-specific format, such as an exe on Windows or a dmg on macOS. Each format must be built on the platform it runs on, there is no cross-platform support. The tool will have options that allow packaged applications to be customized in various ways.

Ah ok, I see. That's fine then

We can leave it as is

Quick question regarding some test failures in CI:

One of the usage example tests for jpackage looks like this:

java -jar ./out/foo/assembly.dest/out.jar
Nov 28, 2024 12:45:43 PM foo.Foo readConf
INFO: Loaded application.conf from resources: Foo Application Conf

Nov 28, 2024 12:45:44 PM foo.Bar lambda$main$0
INFO: Hello World application started successfully

In other words, it uses a logger that prints the current timestamp. I'm wondering if UtestExampleTestSuite is doing a string match against this for its expected output which might be why I'm seeing failures?

I'm guessing I'll need to remove the timestamp, right?

@lihaoyi changes are ready to be merged.

@ayewo looks like some of the test failures are legit

@lihaoyi I believe I've fixed all the legit failures related to my changes.

Looks great, thanks @ayewo ! Please email me your international bank transfer details and I can close out the bounty

Looks great, thanks @ayewo ! Please email me your international bank transfer details and I can close out the bounty

Thanks @lihaoyi! I've just emailed you using the email on your GH profile.

While merging, you forgot to keep me in the co-authors. 😟