Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of ABP-Japanese filters. #1737

Closed
ryanbr opened this issue Jul 4, 2020 · 3 comments · Fixed by #1762
Closed

Removal of ABP-Japanese filters. #1737

ryanbr opened this issue Jul 4, 2020 · 3 comments · Fixed by #1762
Labels
directory-data changes to basic FilterLists data feedback wanted provide your input

Comments

@ryanbr
Copy link

ryanbr commented Jul 4, 2020

We should consider removing ABP-Japanese filters, as unsupported.

The sites aren't minor, and we occasionally have issues with large sites also in Easylist. But we don't ignore users or requests.

Last commit update was in February, but regardless of this. Given the author unwilling to fix any issues, this list should never be used or promoted. It's damaging the user experience with adblockers.

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Jul 4, 2020
@collinbarrett
Copy link
Owner

Thanks. I'm good with removing these.

I had hoped to add back better features around when a list was last updated, how frequently it's updated, and maybe some other measures of "quality" to help users be aware of things like this if they are referred to a list from FilterLists. But, I just haven't had the time to work on it yet.

@DandelionSprout
Copy link
Contributor

DandelionSprout commented Jul 4, 2020

Having thought about the matter for some hours while taking a nap, I think it deserves mention that even if we remove all that project's lists from FilterListsCOM (of which there's 4~7), it's still a selectable included option in all AdGuard versions, because AdGuard doesn't really remove old or bad lists that I know of; they just stamp them as outdated or problematic, while still offering them for easy use.

If we're planning to go full-on cancel culture on that list (Keep in mind I have only the faintest possible idea what that term means), which I don't have much against in this case, we should at least get AdGuard to join us on it.

@collinbarrett
Copy link
Owner

Yeah, I'd ideally like to not remove the lists completely but add some sort of flag to users that they might not be ideal. Hmm... Agreed on AdGuard as well.

We don't have any automated or defined way of flagging lists of lower quality at the moment. We could add a manual tag as a quick/easy answer, but I'm sure these aren't the only lists we have on FilterLists that would fall into this tag, and it'd be subjective and would require manual maintenance.

Something like #371 eventually... Man, I really wish I could carve out more time to add features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data feedback wanted provide your input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants