Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is in relation to #373. I'm not sure if it's a good implementation or not though. What it does is switch to test mode once the "Test" feature is used in webform_civicrm. It does however remove the "Payment Processor Mode".
Or would this be a better implementation?
A use case for this one is to be able to use test payment processor in dev instances while using live on production and that the webform configurations can be sync'ed.
Before
Settings are forced to use only either live or test transactions. Using test mode in dev creates configuration differences when live mode is used for prod.
After
Payment Process Mode selection is removed and end users can either use the normal webform to use live transactions or the "Test" mode in webform to use test transactions.
Comments
I think I missed to either update or remove a few more things although the change here seem to work just fine.