Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixin to colcon-common-extentions #19

Open
sloretz opened this issue Jun 29, 2023 · 2 comments
Open

Add mixin to colcon-common-extentions #19

sloretz opened this issue Jun 29, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@sloretz
Copy link

sloretz commented Jun 29, 2023

Relates to #18

I notice python3-colcon-mixin isn't installed with ros-dev-tools, and isn't part of python3-colcon-common-extensions.

Thoughts on adding it? The mixin documentation is already included in the "reference" section of the colcon documentation, so it would seem natural to me to make it one of the default plugins.

https://colcon.readthedocs.io/en/released/reference/verb/mixin.html

@sloretz sloretz added the enhancement New feature or request label Jun 29, 2023
@Ryanf55
Copy link

Ryanf55 commented Jan 19, 2024

Relates to colcon/colcon-mixin-repository#36

I agree, this is a great enhancement. If you follow the ROS tutorials, then follow the colcon docs, there's a gap.

@Ryanf55
Copy link

Ryanf55 commented Jan 19, 2024

@mjcarrol While it's on your mind from the other PR, do you have any thoughts on this addition? If you like it, I'm happy to do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants