Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only test certain modules #1152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only test certain modules #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/scripts/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ then
EXTRA_OPTIONS="$EXTRA_OPTIONS --benchmark"
fi

python -m pytest $EXTRA_OPTIONS $@
python -m pytest $EXTRA_OPTIONS $@ tests/{benchmarks,stability,workflows,tpch/test_dask.py}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this always ignore the scheduled runs of --tpch-non-dask then?

benchmarks/.github/workflows/tests.yml

Line 110 in 158b07c

- name: Determine if all TPC-H benchmarks should be run

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any desire to run non-Dask TPC-H benchmarks on a schedule. Is there some motivation for this? Or is this just something we're doing because historically we tend to run things on a daily basis?

If so, maybe that makes sense for projects that are included in git-tip because the code used in the benchmarks changes. However, for these projects their software is pinned. I see no reason to run them on any schedule except manually.

Open to disagreement though if people have other thoughts.

Copy link
Contributor

@milesgranger milesgranger Oct 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only introduced by #1083 sparked from this comment: #1044 (comment) by @fjetter

...I want this to run somewhat regularly (every commit, once a day, etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. I disagree with that comment.

@fjetter any objection to not running these benchmarks on a regular basis?

Loading