Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fill the available space in AsyncImage when the painter has no child painter. #2578

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Don't fill the available space in AsyncImage when the painter has no child painter. #2578

merged 2 commits into from
Oct 28, 2024

Conversation

colinrtwhite
Copy link
Member

@colinrtwhite colinrtwhite commented Oct 21, 2024 •
edited
Loading

Resolves: #2349

@colinrtwhite
Copy link
Member Author

colinrtwhite commented Oct 23, 2024 •
edited
Loading

This creates some issues with CrossfadePainter that need to be resolved.

EDIT: This should be resolved.

@colinrtwhite colinrtwhite force-pushed the colin/content_painter_no_intrinsic_size branch from 75f81c2 to 3161e2d Compare October 28, 2024 05:51
@colinrtwhite colinrtwhite changed the title Don't fill the available space in AsyncImage when the painter has no intrinsic size. Don't fill the available space in AsyncImage when the painter has no child painter. Oct 28, 2024
@colinrtwhite colinrtwhite merged commit b2c1aa3 into main Oct 28, 2024
10 checks passed
@colinrtwhite colinrtwhite deleted the colin/content_painter_no_intrinsic_size branch October 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncImage fills the screen if one dimension is not specified and the image is not resolved
1 participant
@colinrtwhite