Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove sorting column #168

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Feature/remove sorting column #168

merged 4 commits into from
Apr 4, 2018

Conversation

ramenhog
Copy link
Collaborator

@ramenhog ramenhog commented Apr 3, 2018

Issue Number

Mentioned in #161

Purpose/Implementation Notes

  • Remove SCORE column for mutations
  • Add default sorting by _score for mutation results instead of symbol

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Functional tests

  • mutations are sorted by _score property, but do not show the column anymore

Screenshots

screen shot 2018-04-03 at 4 11 41 pm

dongbohu
dongbohu approved these changes Apr 4, 2018
View reviewed changes
Copy link

@dongbohu dongbohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ramenhog ramenhog merged commit 51435ed into master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongbohu dongbohu dongbohu approved these changes

Assignees

@dongbohu dongbohu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramenhog @dongbohu