Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover effect for step markers in interpreter #77

Open
willcrichton opened this issue May 10, 2023 · 4 comments
Open

Add hover effect for step markers in interpreter #77

willcrichton opened this issue May 10, 2023 · 4 comments
Labels

Comments

@willcrichton
Copy link
Collaborator

Ideally, the pairs of step markers in the Aquascope interpreter would light up when you hover over them. For example, in this program, if the user mouses over L2, then both L2 markers should light up like this:

example

This would require changing the StepMarkerView: https://github.com/cognitive-engineering-lab/aquascope/blob/b73e572139df571c0f0c38aa0a0b31262f085dc2/frontend/packages/aquascope-editor/src/editor-utils/interpreter.tsx#L758C5-L764

@willcrichton willcrichton added the good first issue Good for newcomers label May 10, 2023
@safwansamsudeen
Copy link

I'd like to take this up too - as before, I'm new, so I'll take up these two issues and play around with them. Apologies if my delivery time is high!

@safwansamsudeen
Copy link

Hey! How do I build an test the app? npm run build in the aquascope-editor directory doesn't work, and cargo build fails with this error:

error: couldn't read crates/mdbook-aquascope/src/../dist/lib.js: No such file or directory (os error 2)
  --> crates/mdbook-aquascope/src/main.rs:15:4
   |
15 |   [make_asset!("lib.js"), make_asset!("lib.css")];
   |    ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `include_bytes` which comes from the expansion of the macro `make_asset` (in Nightly builds, run with -Z macro-backtrace for more info)

error: couldn't read crates/mdbook-aquascope/src/../dist/lib.css: No such file or directory (os error 2)
  --> crates/mdbook-aquascope/src/main.rs:15:27
   |
15 |   [make_asset!("lib.js"), make_asset!("lib.css")];
   |                           ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `include_bytes` which comes from the expansion of the macro `make_asset` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `mdbook-aquascope` (bin "mdbook-aquascope") due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

@willcrichton
Copy link
Collaborator Author

Did you try following the "From Source" instructions? https://github.com/cognitive-engineering-lab/aquascope#from-source

@safwansamsudeen
Copy link

@willcrichton thanks - I have an issue with the instructions, #92

@safwansamsudeen safwansamsudeen removed their assignment Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants