Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error check is insufficient #16

Open
nholland94 opened this issue Jul 10, 2018 · 1 comment
Open

Error check is insufficient #16

nholland94 opened this issue Jul 10, 2018 · 1 comment

Comments

@nholland94
Copy link

The current error check code returns Ok as long as the return code from vulkan is greater than or equal to 0. https://github.com/cogciprocate/voodoo/blob/master/src/error.rs#L206.

However, this is an improper assumption. For instance, if vkWaitForFences times out, VK_TIMEOUT(2) is returned. Similarly, vkGetFenceStatus will return a VK_NOT_READY(1) if the fence is still being used in a queue submission. This means that I am unable to actually use fence synchronization properly through the high level wrapper.

This check should be changed to be more robust and not report Ok when these cases are hit. I'm uncertain, however, if these responses should be considered errors or not. My guess is they probably should be for ease of use of the API, but technically they aren't really errors.

@c0gent
Copy link
Member

c0gent commented Jul 11, 2018

Yes good catch. Would you mind fixing this please? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants