-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tarball URLs? #7
Comments
It must have downloaded the tarball correctly, because I have a feeling the packager is attempting to install |
Some additional context about what I'm trying to do: these URLs point to private modules that have not been published to npm. The tarballs are stored on our CI server. I want to be able to paste one of these URLs into CodeSandbox so I can test a React PR/commit without having to publish a release. |
Intereeesting, it could be that we have to update our |
I think this part might be relevant? dependency-packager/functions/api/index.ts Lines 218 to 221 in de39767
This assumes the version is semver string, but in this case it results in effectively this: const s3Object = await getFileFromS3('vhttps://react-canaries-3adg6ifso.now.sh/13886/react/react.json'); which I'm guessing could cause the S3 request to fail |
By the way, I imagine this isn't a super high priority issue. I can try to submit a PR this weekend, if I can figure out how to get a dev environment set up. Any guidance would be greatly appreciated! |
I have a URL to an npm tarball. I can install it with yarn:
And it also works if I add it to a local
package.json
file:But it doesn't work in CodeSandbox: https://codesandbox.io/s/pmy0470zj7
The text was updated successfully, but these errors were encountered: