Calendar build seems broken

[bast]

https://github.com/coderefinery/calendar/actions/runs/10197929637/job/28211797310

[bast]

Can you see why? I looked through logs but it does not tell me anything.

Paging @rkdarst and @tpfau for help. Thanks!

[tpfau]

Phew...
This stems from unescaped ; in the DESCRIPTION field of a downloaded ics calendar.
the ics library does not like that and fails. I currently don't have the time to look at this in detail, but this is either an error in the downloaded file (; should be escaped in ics fields if I understand this correctly), or an incompatability in the ics library.

[tpfau]

After some tests:
The file is acceptable ICS according to some validators so this could be some issue in the ics library...
I'll try to investigate a bit more.

[tpfau]

Looking at the ICS spec now:
It's a bit unclear... but I have the impression ics sticks closer to the icalendar format than whatever produces the calendar entry we get.
So we get a input from a collaborator which is broken, and I'm not sure what we can/should do about this...
@bast @rkdarst if you have any ideas how to address this, I'm open for suggestions.

[bast]

Temporarily we take out the part that errors just that we get a working calendar back and later we figure out how to error-correct the one that fails?

[bast]

Can you please advise me which collaborator calendar I need to temporarily remove and how? I would like to restore the build and then later we can re-introduce the problematic ones.

[rkdarst]

This might give some hints (I'm looking at it now):
https://icalendar.org/validator.html?url=https://coderefinery.github.io/calendar/all.ics

if you click "show source data", then you can click on the line numbers to take you there (took me a while to figure out I had to show the source before the line links would work...)

[rkdarst]

It seems to be the ENCCS. I'm making a PR with a change that makes it slightyl easier to see (but not much easier...)

[rkdarst]

At least that solves the build on my end.

I have a feeling that my basic hack may have excceded what it can easily handle: I'll see if I can find time to rewrite it on my next trip...

[bast]

Is the fix merged? Or anything for me to merge somewhere?

[rkdarst]

A direct push made the build work. Hasn't shown up my calendars yet though.