Finger are not highlighting in the tutorial

[sangjunp4rk]

fingers are not highlighting. just the keys on the keyboard

[francesar]

is there anyway we can ask chelsy to make svg graphics for the different highlight combinations? would simplify things for us a ton

[sangjunp4rk]

i'll bug her... having trouble getting a hold of her

[sangjunp4rk]

she lost her macbook charger so couldn't access the files. she'll get a replacement soon

[sangjunp4rk]

Chelsy uploaded under CodePhil 2018/TypePhil/TypePhil Icons + Graphics/Hands

[francesar]

cool just saw them now, will also note that it would be cool if we could also get images hands when pressing a shifted key e.g "A" would be left pinky plus left ring finger. All these images would only work for lowercase letters some of the special keys

[sangjunp4rk]

Ahh good point I'll message chelsy about it

[francesar]

ty, hope to have this ready using the images we have now by EOD

[francesar]

are we basing the finger mappings off of a legit source that I should be referencing?

[sangjunp4rk]

it's a lot more iffy for when using the shift key. maybe if the key is normally pressed with the left pinky (like q, a, z) you just shift it to right to the ring finger. And everything else you just use your left pinky for shift? lol so in this case they would never use right pinky for shift (which i never do)

[francesar]

@sangjunp4rk could u replace the paths with the fingers u want high lighted

typephil/src/services/keyboardHighlight.js

Line 20 in 2c84b30

const imageForCharacter = new Map([

[sangjunp4rk]

Updated with key-hands mapping^^

[sangjunp4rk]

Can you default the hands to just empty left/right if the path is broken or mapping doesn't exist?