Fix is string of emojis export #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogroppo
reviewed
Dec 27, 2023
There was a problem hiding this comment.
Hey man, thank you so much to get back at this, however I was thinking and did a bit of research - the list of emojis is changing every year, so I think we should surrender to a more authoritative package like emoji-regex as you used...
Always sad to see a function go, would you mind to remove it? (Thankfully wasn't exported haha)
|
Heyo, ok no problemo. Will remove soon. Definitely sad to see it go as well, but we can hold a procession for it when we meet up. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing export