From f0e182c11ebac27811decb0f8bc94131fd6ec13e Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Tue, 19 Mar 2024 16:00:54 +0700 Subject: [PATCH 1/4] chore: commenting unverified PR --- .github/workflows/label-signing.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/label-signing.yml b/.github/workflows/label-signing.yml index 389ad8844411..677c1b5510e8 100644 --- a/.github/workflows/label-signing.yml +++ b/.github/workflows/label-signing.yml @@ -1,6 +1,6 @@ name: Check Signed PR on: - pull_request: + pull_request_target: branches: - 'develop' - '4.*' @@ -9,20 +9,19 @@ concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} cancel-in-progress: true -permissions: - contents: read - pull-requests: write - jobs: build: name: Check Signed Commit runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write steps: - name: Checkout uses: actions/checkout@v4 - name: Check signed commits in PR - uses: 1Password/check-signed-commits-action@v1 + uses: 1Password/check-signed-commits-action@v1.2.0 with: comment: | You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. See Developer's Certificate of Origin. See [signing][1]. From 5e1009714caf019d965727c4eeb279556b7a8bec Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Tue, 19 Mar 2024 16:02:26 +0700 Subject: [PATCH 2/4] chore: commenting unverified PR --- .github/workflows/label-signing.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/label-signing.yml b/.github/workflows/label-signing.yml index 677c1b5510e8..206deeaff16c 100644 --- a/.github/workflows/label-signing.yml +++ b/.github/workflows/label-signing.yml @@ -4,6 +4,7 @@ on: branches: - 'develop' - '4.*' + - '.github/workflows/label-signing.yml' concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} From a811bb686abdb467cd291213702aafb8b0daa0e6 Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Tue, 19 Mar 2024 16:19:46 +0700 Subject: [PATCH 3/4] remove wrong branch --- .github/workflows/label-signing.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/label-signing.yml b/.github/workflows/label-signing.yml index 206deeaff16c..677c1b5510e8 100644 --- a/.github/workflows/label-signing.yml +++ b/.github/workflows/label-signing.yml @@ -4,7 +4,6 @@ on: branches: - 'develop' - '4.*' - - '.github/workflows/label-signing.yml' concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} From f14dc1c376b76cc50ca4ab1e2ca12eff0d4be1b6 Mon Sep 17 00:00:00 2001 From: Denny Septian Panggabean Date: Tue, 19 Mar 2024 16:45:19 +0700 Subject: [PATCH 4/4] fix: comment link --- .github/workflows/label-signing.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/label-signing.yml b/.github/workflows/label-signing.yml index 677c1b5510e8..c4687c038815 100644 --- a/.github/workflows/label-signing.yml +++ b/.github/workflows/label-signing.yml @@ -24,8 +24,6 @@ jobs: uses: 1Password/check-signed-commits-action@v1.2.0 with: comment: | - You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. See Developer's Certificate of Origin. See [signing][1]. + You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. See Developer's Certificate of Origin. See [signing](https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing). - **Note that all your commits must be signed.** If you have an unsigned commit, you can sign the previous commits by referring to [gpg-signing-old-commits][2]. - [1]: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing - [2]: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits + **Note that all your commits must be signed.** If you have an unsigned commit, you can sign the previous commits by referring to [gpg-signing-old-commits](https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits).