Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmdShell does not escape asterisk arg value (SCM-763) #37

Open
michael-o opened this issue Apr 2, 2018 · 2 comments
Open

CmdShell does not escape asterisk arg value (SCM-763) #37

michael-o opened this issue Apr 2, 2018 · 2 comments

Comments

@michael-o
Copy link
Member

michael-o commented Apr 2, 2018

This was found during SCM-763.

Consider your want to pass a password (on Windows) with asterisk: S8p3r*S3cr3t. The escaped outcome is S8p3r*S3cr3t. No change, but to pass an asterisk you need to quote the entire string otherwise the shell will expand the asterisk. Correct value would be: "S8p3r*S3cr3t"

Currently, this is impossible in Plexus Utils.

@belingueres
Copy link
Contributor

@michael-o is this still an issue? I see SCM-763 is fixed now.

@michael-o
Copy link
Member Author

Yes, it is. The entire process execution suffers from one serious flaw that it executes a local shell rather than providing it to the system directory. The shell will do its own replacement which hasn't been espaced by this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants