You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding and removing repeatedly in a list of ValueSources and InterpolationPostProcessor is costly, mainly the final removing ValueSource and InterpolationPostProcessor part since remove is an O(n) operation on an ArrayList.
Instead, modify the Interpolator interface to either directly set both lists and interpolate from there, or either add a new interpolate method that takes both lists as parameters.
The text was updated successfully, but these errors were encountered:
Looking at: https://github.com/apache/maven/blob/a2b800de32cdb9adc1e64a43a0fc32e3ba878103/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/AbstractStringBasedModelInterpolator.java#L233
Adding and removing repeatedly in a list of ValueSources and InterpolationPostProcessor is costly, mainly the final removing ValueSource and InterpolationPostProcessor part since remove is an O(n) operation on an ArrayList.
Instead, modify the Interpolator interface to either directly set both lists and interpolate from there, or either add a new interpolate method that takes both lists as parameters.
The text was updated successfully, but these errors were encountered: