Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please output INFO messages in DefaultBuildContext.addMessage #20

Open
rakus opened this issue Mar 6, 2022 · 3 comments
Open

Please output INFO messages in DefaultBuildContext.addMessage #20

rakus opened this issue Mar 6, 2022 · 3 comments

Comments

@rakus
Copy link

rakus commented Mar 6, 2022

Thank you very much for reviving this project. It was strange to have so many components that depend on a module that was archived.

Please consider to expand the method DefaultBuildContext.addMessage(...) to also log info messages. Currently only ERROR and WARNING are printed. This would mean adding a new constant SEVERITY_INFO to the interface BuildContext and extending the switch statement in the addMessage(...) implementation. Maybe also a default branch would be useful.

Note that adding a INFO message (severity == 0) inside Eclipse works and adds a INFO IMarker to the file (tested with 2021-12).

@rakus
Copy link
Author

rakus commented Mar 6, 2022

Just realized: Adding a constant to the interface BuildContext would break binary compatibility wit 007. Not good.
Anyway addMessage(....) could handle severity == 0 as INFO.

@slachiewicz
Copy link
Member

Worth to add to 1.0.0 @olamy

@laeubi
Copy link
Collaborator

laeubi commented Oct 5, 2022

Good idea! Why not make it 1.0.0 now? also change the package name and then all its fine, I don't think binary compatibility with 007 is anything useful:

  1. There are mostly consumers of the API so this won't break for them
  2. Don't know if there are other implmentors beside m2e and as we need to possibly adapt here anyways it won't be an issue at all
  3. Why would adding a constant break compatibility anyways?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants