Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fixed Format Ruler #350

Closed
thomprl opened this issue Dec 12, 2024 · 1 comment · Fixed by #351
Closed

BUG: Fixed Format Ruler #350

thomprl opened this issue Dec 12, 2024 · 1 comment · Fixed by #351
Assignees

Comments

@thomprl
Copy link

thomprl commented Dec 12, 2024

I was just playing around with the new fixed format stuff and I think I found a small bug in the ruler not displaying in a certain situation. So line 1 of the code has an H spec. Line 2 has an F spec. The ruler is not showing on line 2. It will show on line 3. If I put a blank line after the H spec it will display the ruler. Also the Ctrl+Shift+F4 won't work on the F spec as well unless you put the blank line between it. If I put a blank line before the H spec and leave no blank line between the H and F spec it will work. I'm not getting and ruler for the H spec which might be by design.

     H DFTACTGRP(*NO) ACTGRP(*CALLER)
     FCRTSQLXFMNCF   E             WORKSTN INDDS(Indicators)
     D System_Table_Schema...
     D                 S             10

image

@thomprl
Copy link
Author

thomprl commented Dec 12, 2024

Also looked at your PR. I guessing I and O specs aren't supported yet (or not planned) and I understand why (either way) since you can have two varieties of these. I think if you really wanted to implement it you could look at position 7 and/or 17 on the I specs and see its not blank that's the equivalent of an IPI in SEU, If those are blank then it's a IPJ.

On the O specs position 7 and/or 17 not blanks than it's a IPO spec from SEU. If it is blank than it's a IPP spec in SEU.

Those might not be the only scenarios but those are pretty common.

I-Spec Example

     ICUST      NS
     I                                  1    1  STATUS  
     I                                  2    8 0CUSNO

O-Spec Example

     OQSYSPRT   E   N21      HEADER         1       
     O         AND  N41                             
     O                       CUSNO               75 

@worksofliam worksofliam self-assigned this Dec 12, 2024
@worksofliam worksofliam transferred this issue from codefori/vscode-ibmi Dec 12, 2024
@worksofliam worksofliam linked a pull request Dec 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants