Move after_n_builds earlier in the report processing cycle.

[drazisil-codecov]

Currently, after_n_builds is a notification setting that tells Codecov to only send comments and statuses after N uploads have been received.

This does not prevent Codecov for running coverage calculations early though, and those results will show in the Codecov UI.

The ask is for after_n_builds to also control if Codedcov runs the coverage calculation before the expected number of uploads are received. This would prevent expected bad information to be shown to the customer via any method.

[gondalez]

Hi @drazisil-codecov 👋

My team is affected by this too.

I initially used after_n_builds and had the same result (multiple partial and early notifications).

So I switched from that to using the send-notificaitons command on this CLI tool in conjunction with notify: manual_trigger in the yml file as suggested in the docs.

I thought that might solve the issue.

(I also figured using manual_trigger is nicer because using after_n_builds would mean having to remember to change that setting if we ever change our CI config to have more or less parallel builds.)

We are still getting the multiple early and partial notifications per this issue.

I have a fairly long-running support ticket (zendesk #111250) on the issue.

In that support ticket the support tech said in the logs he saw that some uploads failed processing on the Codecov side but then were retried and succeeded.

I wonder if this bug is that the notifications are sent when all jobs complete regardless of if each job was a success or a failure?
Just a hunch :)

[gondalez]

This issue is the only negative thing about Codecov for us by the way.
Everything else is great. We especially appreciate the branching coverage support and also the github annotation support 👌

[drazisil-codecov]

👋 @rohan-at-sentry Making sure you have seen this :)

[rohan-at-sentry]

This is being tracked here - codecov/engineering-team#1245