Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how models and parts are created and maintained #70

Open
coavins opened this issue Nov 26, 2023 · 2 comments · May be fixed by #94
Open

Refactor how models and parts are created and maintained #70

coavins opened this issue Nov 26, 2023 · 2 comments · May be fixed by #94
Assignees
Labels
codebase enhancement New feature or request

Comments

@coavins
Copy link
Owner

coavins commented Nov 26, 2023

Adding new models, parts, and Zomboid items involves way too many steps in too many separate files. There should be a way to define models and parts in one place (e.g. yaml files) and use those to generate the actual source files used by the game (e.g. CoavinsModels.lua and the parts list in FirearmsHelper.lua)

I think this could be easier to maintain as the list of models and parts grows larger.

@coavins coavins self-assigned this Nov 26, 2023
@coavins coavins added the enhancement New feature or request label Nov 26, 2023
@coavins
Copy link
Owner Author

coavins commented Nov 27, 2023

One notable issue is that for parts that hold or insert into another part, you have to define this relationship from both sides which leaves room for error. A refactor should fix this so you only have to define the relationship once.

@macinsight
Copy link
Collaborator

It could be a good idea (for a start) to, if possible, move out the parts relationship in FirearmsHelper.lua into different files per weapon type, to clean that up. Then we could build something to build the rest of the content from these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase enhancement New feature or request
Projects
None yet
2 participants