Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand models #21

Open
coavins opened this issue Aug 4, 2022 · 2 comments · Fixed by #83
Open

Expand models #21

coavins opened this issue Aug 4, 2022 · 2 comments · Fixed by #83
Labels
model New Model addition
Milestone

Comments

@coavins
Copy link
Owner

coavins commented Aug 4, 2022

Maybe add more items to each model, like grip, trigger, mag well, hammer, firing pin, etc.

@coavins coavins added this to the Next milestone Aug 4, 2022
@coavins coavins added the model New Model addition label Nov 27, 2023
@coavins
Copy link
Owner Author

coavins commented Nov 27, 2023

A discussion should happen here about how detailed we really want the models to be. How much is too much?

@macinsight
Copy link
Collaborator

I've been so far keeping it rather simple with just differing between caliber types and functionally radically different model types, so differing between a .45 ACP Glock and a 9mm Glock, but not between a .45 ACP Colt 1911 and a .45 ACP Glock.

So far there's nothing like a difference between a Glock 17 with a barrel length of 114mm and a Glock 17L with a barrel length of 153mm.

@macinsight macinsight mentioned this issue Nov 27, 2023
4 tasks
@macinsight macinsight linked a pull request Nov 27, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model New Model addition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants