Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repulsion prior documentation #199

Open
jasonzzj97 opened this issue Aug 17, 2021 · 1 comment
Open

Repulsion prior documentation #199

jasonzzj97 opened this issue Aug 17, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jasonzzj97
Copy link

Hi,

There are inconsistent descriptions of RepulsionLayer comments and the actual calculation formula.

U_repulsion_ij = (sigma_{ij} / r_{ij}) ^ exp_{ij}

and

energy = torch.sum((self.repulsion_parameters[0, :]/in_feat)
                           ** self.repulsion_parameters[1, :],
                           1).reshape(n, 1) / 2
@nec4
Copy link
Contributor

nec4 commented Aug 18, 2021

Thanks for finding this! The repulsion prior is very simple, so for decent initial repulsion parameter choices I believe the network should be able learn corrections to the prior if needed. Regardless, the factor of two should not be there. I will add it to my list of things to do.

@nec4 nec4 self-assigned this Aug 18, 2021
@nec4 nec4 added the bug Something isn't working label Aug 18, 2021
@nec4 nec4 mentioned this issue Aug 22, 2021
5 tasks
@nec4 nec4 mentioned this issue Sep 12, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants