Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics unit of beta in GeometryStatistics() #197

Open
jasonzzj97 opened this issue Aug 7, 2021 · 2 comments
Open

Physics unit of beta in GeometryStatistics() #197

jasonzzj97 opened this issue Aug 7, 2021 · 2 comments
Assignees

Comments

@jasonzzj97
Copy link

jasonzzj97 commented Aug 7, 2021

Hi,

Please correct me if I'm wrong, I feel the physics unit of beta in GeometryStatistics() is incorrect.

beta : float
1/(Boltzmann constant)/(temperature) if temperature is not None in
units of kcal per mole; otherwise 1.0

if the following formula is used to calculate beta,
self.beta = JPERKCAL/KBOLTZMANN/AVOGADRO/self.temperature

The unit of physics constants:
KBOLTZMANN: J/K
AVOGADRO: mol^-1
temperature: K
JPERKCAL: J/kcal

J/kcal/JxKxmol/K=mol/kcal

@nec4
Copy link
Contributor

nec4 commented Aug 9, 2021

Thanks! I will take a look shortly.

@nec4
Copy link
Contributor

nec4 commented Aug 9, 2021

I think that this is the way it should be - at least for our data, the forces were saved in units of kcal/mol/aa. That being said, I think this should explicitly be mentioned in the docstring. I will make a PR about it.

@nec4 nec4 self-assigned this Aug 9, 2021
@nec4 nec4 mentioned this issue Aug 22, 2021
5 tasks
@nec4 nec4 mentioned this issue Sep 12, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants