Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrape.js: typeError - cannot read property 'line' of undefined #163

Closed
li-boxuan opened this issue Oct 26, 2018 · 2 comments
Closed

scrape.js: typeError - cannot read property 'line' of undefined #163

li-boxuan opened this issue Oct 26, 2018 · 2 comments
Assignees
@li-boxuan
Labels
difficulty/medium importance/high type/bug

Comments

@li-boxuan
Copy link
Member

See #161 (comment)

(node:1599) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'line' of undefined
@li-boxuan li-boxuan self-assigned this Oct 26, 2018
@li-boxuan li-boxuan mentioned this issue Oct 26, 2018
Merged
li-boxuan added a commit to li-boxuan/gci-leaders that referenced this issue Oct 26, 2018
@li-boxuan
scrape.js: Catch exception for GitHub GraphQL
5a451b6 
Fixes coala#163
@li-boxuan
Copy link
Member Author

This is an upstream issue, but we can have a workaround (actually we should do so) by using try catch block.

@li-boxuan
Copy link
Member Author

li-boxuan commented Oct 26, 2018 •
edited
Loading

I've created an issue on upstream project: nordsimon/graphql-client#9

li-boxuan added a commit to li-boxuan/gci-leaders that referenced this issue Oct 27, 2018
@li-boxuan
scrape.js: Catch exception for GitHub GraphQL
2ea74bc 
Fixes coala#163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@li-boxuan li-boxuan

Labels
difficulty/medium importance/high type/bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@li-boxuan