-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mavenisation of forester #12
Comments
@josemduarte The issue here isn't really what build system forester uses (ant or maven). The problem is that we maven users would like to have forester in maven central, so that we can automatically pull it as a dependency. Thus, the question is really who should be responsible for pushing new versions. The options are
Both options are possible with either ant or maven, but both would be easier if forester switched to maven. The second option is the officially preferred way, but it would require more work initially. |
Thanks @sbliven . I understand the main issue is pushing the jar to maven central. I simply thought mavenization would make things easier and would allow for a more automated way to publish to maven central. In my fork I've already made some progress and got the project mavenized. I'll submit a pull request as soon as I can check that everything is alright. |
+1 to this. We're also using forester via maven at CyVerse (formerly iPlant Collaborative), and we've had to switch to using biojava's thirdparty copy of forester in sonatype OSS releases repository to get our stuff to build: https://github.com/cyverse/DE/blob/919d2d21d2cc1c9aa42b655b7a22c8844ea7ede7/services/terrain/project.clj#L34 |
Happy that it helps. You can use now version 1.038 which contains some important bug fixes, see the biojava pom: https://github.com/biojava/biojava/blob/master/pom.xml#L439 |
At BioJava we are using the forester library within the biojava-phylo module. It's all working great with forester, except for the dependency management. We use maven (as many people these days in the java world) but forester does not exist in maven central. In the past we've solved this by publishing a forester artifact under the org.biojava.thirdparty group, but that required some manual work. We now need to update to version 1.038 of forester (see biojava/biojava#350) so we are going to go through the process of publishing to maven again.
To avoid some of that work for the future I'm considering submitting a pull request to mavenise forester. Would that be a welcome solution? It would require some reorganisation of the project so that it follows the maven layout convention (java code under src/main/java, java-related resources under src/main/resources, testing java code under src/test/java).
The text was updated successfully, but these errors were encountered: