Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players now get visual 'Balloon' Alert when Defender Crest is Lowered. #7720

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Dec 2, 2024

TM before Merging

About the pull request

This PR add "balloon alert" above defender, warning them that crest is lowered and cannot use other ability.
(check video to see what balloon alert is)

Explain why it's good for the game

I am not only person who had this issue, when crest was lowered and didn't notice that during "heat of battle" and try to use tail swing or fortify to only get killed by that mistake, there is no big chat alert to make people realize they have it lowered.

This PR changes that by adding "Balloon Alert" (the ones that spitters have when using 'charge_spit' ability.

Testing Photographs and Procedure

Click HERE to see that Video:
2024-12-02.20-41-26.mp4

Changelog

🆑 Venuska1117
code: Add "Delay" option for balloon alerts to prevent notification spam.
qol: Added Balloon Alerts to notify player that crest is lowered when trying to use Tail Swing or Fortify.
/:cl:

- When crest is lowered, it will notify player that crest is lowered.
- balloon alerts now include "delay" so you don't need to create shit ton of code to prevent text spam.
@cmss13-ci cmss13-ci bot added Feature Feature coder badge Quality of Life Make the game harder to play Code Improvement Make the code longer labels Dec 2, 2024
@Venuska1117 Venuska1117 marked this pull request as draft December 2, 2024 20:10
@Venuska1117 Venuska1117 marked this pull request as ready for review December 2, 2024 21:24
@Venuska1117 Venuska1117 changed the title Balloon Alerts for Defender Lowered Crest! Player Alerts for Defender Lowered Crest! Dec 2, 2024
@Venuska1117 Venuska1117 changed the title Player Alerts for Defender Lowered Crest! Players now get visual 'Balloon' Alert when Crest is Lowered. Dec 2, 2024
@Venuska1117 Venuska1117 changed the title Players now get visual 'Balloon' Alert when Crest is Lowered. Players now get visual 'Balloon' Alert when Defender Lower its Crest is Lowered. Dec 3, 2024
@Venuska1117 Venuska1117 changed the title Players now get visual 'Balloon' Alert when Defender Lower its Crest is Lowered. Players now get visual 'Balloon' Alert when Defender Crest is Lowered. Dec 3, 2024
@harryob harryob marked this pull request as draft December 4, 2024 10:53
@Venuska1117 Venuska1117 requested a review from harryob December 4, 2024 12:22
@Venuska1117 Venuska1117 marked this pull request as ready for review December 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants