Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Improve performance on snapshot update #3

Open
Phil2812 opened this issue Aug 11, 2016 · 1 comment
Open

Improve performance on snapshot update #3

Phil2812 opened this issue Aug 11, 2016 · 1 comment
Assignees

Comments

@Phil2812
Copy link
Collaborator

Phil2812 commented Aug 11, 2016

Currently, we are wasting too much time on a snapshot update (around 500ms per update on my machine, even for snapshots without any data changes). The wasted time may be reduced by implementing shouldComponentUpdate hooks for most components.

Also, we should be adding unique keys to component instances. I suggest using the unique object ids already present in the JSON and adding the "@ id" attribute to the TypeScript interfaces.

@Phil2812 Phil2812 self-assigned this Aug 11, 2016
@Phil2812 Phil2812 changed the title Improve performance on update Improve performance on snapshot update Aug 11, 2016
@Phil2812
Copy link
Collaborator Author

We might also consider using immutable.js to easily save more wasted render time in React, as it makes (deep and shallow) comparisons of snapshot elements straightforward and performant.

Phil2812 added a commit that referenced this issue Sep 1, 2017
Merge release/1.1.0 into dev
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant