Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WF for 2024 PbPb skim #46589

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

youyingli
Copy link
Contributor

PR description:

Add the workflow for the 2024 PbPb skim with MC generation inside relval to try to solve the issue #46586

@mmusich @AdrianoDee @mandrenguyen

PR validation:

runTheMatrix.py -w "standard" -l 143.201,143.202

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will make a backport to 14_1_X if passd.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46589/42481

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

A new Pull Request was created by @youyingli for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor

please test workflows 143.201,143.202

@@ -559,6 +559,10 @@
workflows[142.901] = ['',['RunUPC2023','RECODR3_2024_UPC','HARVESTDPROMPTR3']]
workflows[142.902] = ['',['RunUPC2023','RECODR3_2024_HIN','HARVESTDPROMPTR3']]

### run3-2024 skim (2024 HI MC temp)
workflows[143.201] = ['',['HydjetQ_B12_5362GeV_2024','DIGIHI2024','SKIMHIFORWARDRUN3_2024','HARVESTHI2024']]
workflows[143.202] = ['',['HydjetQ_B12_5362GeV_2024','DIGIHI2024','SKIMHIPHYSICSRAWPRIMERUN3_2024','HARVESTHI2024']]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think the rawprime wf should use the rawprime reco.
see

workflows[161.03] = ['',['HydjetQ_MinBias_5362GeV_2024','DIGIHI2024','RAWPRIMESIMHI18','RECOHI2024PROD','MINIHI2023PROD']]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's follow this wf.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if you run SKIMHIPHYSICSRAWPRIMERUN3_2024 as defined right now, you are not using the strip approximate cluster modifier used in RECOHI2024PROD:

steps['RECOHI2024PROD']=merge([hiDefaults2024_approxClusters,{'-s':'RAW2DIGI,L1Reco,RECO',
'--datatier':'AODSIM',
'--eventcontent':'AODSIM',
'--era':'Run3_pp_on_PbPb_2024',
},step3Up2015Defaults])

then's pointless to run the RAWPRIMESIMHI18 step in between as you'll just consume the regular raw and not rawprime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Now it's added. If it's correct, please test.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46589/42486

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

Pull request #46589 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@srimanob
Copy link
Contributor

srimanob commented Nov 3, 2024

test parameters:

  • workflows = 143.201,143.202
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@srimanob
Copy link
Contributor

srimanob commented Nov 3, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46589/42489

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

Pull request #46589 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Nov 3, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2024

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29b426/42567/summary.html
COMMIT: 6011a57
CMSSW: CMSSW_14_2_X_2024-11-03-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46589/42567/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569567
  • DQMHistoTests: Total failures: 436
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3569111
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

The new wfs test the 2024 HI skims and produce the expected outputs.

@Moanwar
Copy link
Contributor

Moanwar commented Nov 5, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 59389d8 into cms-sw:master Nov 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants