-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WF for 2024 PbPb skim #46589
Add WF for 2024 PbPb skim #46589
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46589/42481
|
A new Pull Request was created by @youyingli for master. It involves the following packages:
@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflows 143.201,143.202 |
@@ -559,6 +559,10 @@ | |||
workflows[142.901] = ['',['RunUPC2023','RECODR3_2024_UPC','HARVESTDPROMPTR3']] | |||
workflows[142.902] = ['',['RunUPC2023','RECODR3_2024_HIN','HARVESTDPROMPTR3']] | |||
|
|||
### run3-2024 skim (2024 HI MC temp) | |||
workflows[143.201] = ['',['HydjetQ_B12_5362GeV_2024','DIGIHI2024','SKIMHIFORWARDRUN3_2024','HARVESTHI2024']] | |||
workflows[143.202] = ['',['HydjetQ_B12_5362GeV_2024','DIGIHI2024','SKIMHIPHYSICSRAWPRIMERUN3_2024','HARVESTHI2024']] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I think the rawprime wf should use the rawprime reco.
see
workflows[161.03] = ['',['HydjetQ_MinBias_5362GeV_2024','DIGIHI2024','RAWPRIMESIMHI18','RECOHI2024PROD','MINIHI2023PROD']] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's follow this wf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if you run SKIMHIPHYSICSRAWPRIMERUN3_2024
as defined right now, you are not using the strip approximate cluster modifier used in RECOHI2024PROD
:
cmssw/Configuration/PyReleaseValidation/python/relval_steps.py
Lines 3261 to 3266 in ce4d0b1
steps['RECOHI2024PROD']=merge([hiDefaults2024_approxClusters,{'-s':'RAW2DIGI,L1Reco,RECO', | |
'--datatier':'AODSIM', | |
'--eventcontent':'AODSIM', | |
'--era':'Run3_pp_on_PbPb_2024', | |
},step3Up2015Defaults]) | |
then's pointless to run the RAWPRIMESIMHI18
step in between as you'll just consume the regular raw and not rawprime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Now it's added. If it's correct, please test.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46589/42486
|
Pull request #46589 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again. |
test parameters:
|
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46589/42489
|
Pull request #46589 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 68KB to repository Comparison SummarySummary:
|
+pdmv The new wfs test the 2024 HI skims and produce the expected outputs. |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add the workflow for the 2024 PbPb skim with MC generation inside relval to try to solve the issue #46586
@mmusich @AdrianoDee @mandrenguyen
PR validation:
runTheMatrix.py -w "standard" -l 143.201,143.202
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Will make a backport to 14_1_X if passd.