Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of relval testing for PbPb skims #46586

Open
mmusich opened this issue Nov 2, 2024 · 12 comments
Open

Lack of relval testing for PbPb skims #46586

mmusich opened this issue Nov 2, 2024 · 12 comments

Comments

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2024

Recently a new release (CMSSW_14_1_4_patch4) [1] was made available to fix few issues observed during the 2024 Heavy Ion setup runs and to introduce new / modify physics skims for the PbPb run, including PbPbZMu (see PR [2]).
A Tier 0 replay [3] was started in order to test the new release before putting in production and failure was observed in one of PbPb physics skims (PbPbZMu, details at [3] and #46458 (comment)).
As discussed in the tentative fix PR (#46584 (comment)) it appears there's no appropriate set of PbPb relvals to test the Heavy Ion skims.
It would be appropriate to add them to spot issues when changes are made in release, before leading to a crash in Tier0.


[1] Production Release CMSSW_14_1_4_patch4 Available Now
[2] #46458
[3] Replay for CMSSW_14_1_4_patch4
[4] Replay for CMSSW_14_1_4_patch4 - #3

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

A new Issue was created by @mmusich.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

assign pdmv

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

@youyingli @mandrenguyen FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

New categories assigned: pdmv

@AdrianoDee,@DickyChant,@miquork you have been requested to review this Pull request/Issue and eventually sign? Thanks

@youyingli
Copy link
Contributor

@youyingli @mandrenguyen FYI

These new PbPb skims have new triggers from 2024. There is no RAW data for test. But for the PbPbZMu skim with the same trigger as 2023, I can quickly make a PR to build a workflow for this skim with 2023 RAW data.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

These new PbPb skims have new triggers from 2024. There is no RAW data for test.

what about MC? The new menu is available in release since last week (see #46508).
Also there are a couple of PbPb setup runs that can be used taken during the week (e.g. 387456, which is the run in which the Tier0 replay failed)

@youyingli
Copy link
Contributor

These new PbPb skims have new triggers from 2024. There is no RAW data for test.

what about MC? The new menu is available in release since last week (see #46508). Also there are a couple of PbPb setup runs that can be used taken during the week (e.g. 387456, which is the run in which the Tier0 replay failed)

As I find out the following are DISK available, I could use these files temporarily to make a PR for the test.

/HIForward10/Tier0_HIREPLAY_2024-v1194758/RAW
/HIPhysicsRawPrime1/Tier0_HIREPLAY_2024-v1194758/RAW

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Nov 2, 2024

what about MC?

I was thinking the same thing. What is preventing us from testing the SKIMs on MC?

Edit: in general, also for pp.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

I could use these files temporarily to make a PR for the test.

I'd rather NOT depend on the products of a Tier0 replay for relval tests

@mandrenguyen
Copy link
Contributor

what about MC?

I was thinking the same thing. What is preventing us from testing the SKIMs on MC?

Edit: in general, also for pp.

We don't have the 2024 trigger menu yet in MC.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

We don't have the 2024 trigger menu yet in MC.

how come? can't you just generate some on the fly in relvals? As mentioned the menu is in release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants