Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1TriggerScouting/OnlineProcessing to DAQ and cleanup old packages #2278

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

smorovic
Copy link
Contributor

@smorovic smorovic commented Jul 1, 2024

Adding new package to daq supervision.

Package is submitted to CMSSW here:
cms-sw/cmssw#45350

Old DAQ packages that no longer exist in the CMSSW codebase (Run1 period) are cleaned up.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

A new Pull Request was created by @smorovic for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

@smorovic , we can not remove/cleanup old packages as old releases still contain these and PRs for old releases need these

@smorovic smorovic force-pushed the daq-l1scouting-onlineprocessing branch from e1b1755 to 713de39 Compare July 1, 2024 22:21
@smorovic
Copy link
Contributor Author

smorovic commented Jul 1, 2024

OK, I reverted that commit.

There is little probability anything there will need to be updated (old DAQ event filter code), but there is no real need to remove references either.

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit 629f10f into cms-sw:master Jul 1, 2024
3 of 4 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants