Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Muons configs #99

Open
bonanomi opened this issue Dec 3, 2024 · 1 comment
Open

Fix Muons configs #99

bonanomi opened this issue Dec 3, 2024 · 1 comment
Assignees

Comments

@bonanomi
Copy link
Collaborator

bonanomi commented Dec 3, 2024

@Lara813 spotted a bug in the config for muons (for sure in this one), but maybe also in others.

The reference_object should use the [GenPart](https://github.com/cms-l1-dpg/Phase2-L1MenuTools/blob/main/configs/V44nano/objects/GenPart.yaml):object:region definition, as done, eg, in the electron_matching.yaml config.

It should be:

TkMuonsMatchingBarrel:
  sample: DYLL_M50
  version: V44nano
  match_test_to_ref: True
  reference_object:
    GenPart:reference_muon:barrel_muon: "pt"
  test_objects:
    # L1gmtMuon:default:barrel: "pt"
    L1gmtTkMuon:default:barrel: "pt"
    L1gmtTkMuon:VLoose:barrel: "pt"
    L1gmtTkMuon:Loose:barrel: "pt"
    L1gmtTkMuon:Medium:barrel: "pt"
    L1gmtTkMuon:Tight:barrel: "pt"
  xlabel: "Gen. $p_T$ (GeV)"
  ylabel: "Matching Efficiency (barrel)"
  binning:
    min: 0
    max: 100
    step: 3

Also note that for muons in GenPart there are two regions: barrel_muon and endcap_muon that should be used, since also the overlap region should be used for muons.

@Lara813 Lara813 self-assigned this Dec 17, 2024
@Lara813
Copy link
Collaborator

Lara813 commented Dec 17, 2024

Also tau, jet and photon configs and exclude 'reference' in object names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants