Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidateDatacards.py cannot read Datacards which have one root file for each systematic #245

Open
Andrej-CMS opened this issue Jun 12, 2020 · 2 comments

Comments

@Andrej-CMS
Copy link

Hello,

As the title says: I have a datacard with one root file per systematic (70 systematics total). This would take hours to hadd into one file and I would not like to do that.
text2workspace can read such datacards without any problem and create a workspace, but ValidateDatacards.py seems not be able to do that and prints the error below.

Is it possible to add this functionality?

Kind regards,
Andrej

[SetFlag] Changing value of flag "check-negative-bins-on-import" from 1 to 0
[SetFlag] Changing value of flag "workspaces-use-clone" from 0 to 1
Error in TSystem::ExpandFileName: input: ../../../miniTreeHistograms/MergedTrees/miniTree$SYSTEMATIC.root, output: ../../../miniTreeHistograms/MergedTrees/miniTree$SYSTEMATIC.root
Error in TFile::TFile: error expanding path ../../../miniTreeHistograms/MergedTrees/miniTree$SYSTEMATIC.root
Traceback (most recent call last):
File "/nfs/dust/cms/user/asaibel/PhDWorkFolder/HiggsCombineTool/SL7/CMSSW_10_2_13/bin/slc7_amd64_gcc700/ValidateDatacards.py", line 110, in
cb.ParseDatacard(args.cards,"","",mass=args.mass)
File "/nfs/dust/cms/user/asaibel/PhDWorkFolder/HiggsCombineTool/SL7/CMSSW_10_2_13/python/CombineHarvester/CombineTools/ch.py", line 21, in ParseDatacard
return self.ParseDatacard(card, analysis, era, channel, bin_id, mass)
RuntimeError:


Context: Function ch::GetClonedTH1 at
/nfs/dust/cms/user/asaibel/PhDWorkFolder/HiggsCombineTool/SL7/CMSSW_10_2_13/src/CombineHarvester/CombineTools/src/TFileIO.cc:21
Problem: TH1 Nominal/combined/GreaterThreeBTag/DeltaRbin1/GreaterThreeJet/data_obs/jet4_btag not found in ../../../miniTreeHistograms/MergedTrees/miniTree$SYSTEMATIC.root

@Andrej-CMS
Copy link
Author

@adewit
Are there any plans to change this behavior? The hadding of the files takes really forever

@adewit
Copy link
Collaborator

adewit commented Oct 22, 2020

Hi Andrej,

Sorry for not replying earlier. CombineHarvester is indeed not able to parse such datacards at the moment. This functionality can probably be added, but it's not a small amount of work and as (so far) this is the only analysis we know of that requires this feature we can't promise a fix on a short timescale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants