Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getRawWeatherGroupData() #131

Open
Tracked by #72
KarelWintersky opened this issue Feb 14, 2019 · 3 comments
Open
Tracked by #72

getRawWeatherGroupData() #131

KarelWintersky opened this issue Feb 14, 2019 · 3 comments
Labels
enhancement

Comments

@KarelWintersky
Copy link

pls, add option for format data fetched, such as getRawWeatherData()
@cmfcmf
Copy link
Owner

cmfcmf commented May 29, 2019

I'm sorry for the late response @KarelWintersky.
It is unclear to me what you are asking for. Could you elaborate on your request?

@KarelWintersky
Copy link
Author 

public function getRawWeatherData($query, $units = 'imperial', $lang = 'en', $appid = '', $mode = 'xml')

where $mode - The format of the data fetched. Possible values are 'json', 'html' and 'xml' (default).

So,

public function getRawWeatherGroupData($ids, $units = 'imperial', $lang = 'en', $appid = '')

have no option for data fetched, it hardcoded to JSON.

Can I make my own pull request for this?

@cmfcmf
Copy link
Owner

cmfcmf commented May 29, 2019

Oh! I understand now. Feel free to create a PR for that 👍

@cmfcmf cmfcmf mentioned this issue May 29, 2019
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmfcmf @KarelWintersky