fix: overwrite gasLeft topic with the value in the original transaction receipt when re-executing a transaction
#830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carneiro-cw
reviewed
May 13, 2024
marcospb19-cw
force-pushed
the
copy-gasLeft-from-original-transaction-receipt-on-import
branch
from
736388e to
354347a
Compare
|
Running the log fixing function only in case the comparison fails might be more performatic since it's not common for logs to contain the EDIT: Actually, since this affects the mainnet import as well I think I'm more inclined to believe it is worth it. |
marcospb19-cw
force-pushed
the
copy-gasLeft-from-original-transaction-receipt-on-import
branch
2 times, most recently
from
7e0ca48 to
59af95e
Compare
dinhani-cw
reviewed
May 13, 2024
dinhani-cw
reviewed
May 13, 2024
marcospb19-cw
force-pushed
the
copy-gasLeft-from-original-transaction-receipt-on-import
branch
6 times, most recently
from
8e514c7 to
b6108e1
Compare
|
Please put the fixes based on the receipt inside the new function It is called in more than one place. stratus/src/eth/primitives/execution.rs Line 183 in 340de83 |
dinhani-cw
reviewed
May 15, 2024
when re-executing the imported transaction, the `gasLeft` topic in logs diverges from what is received in the receipt, this topic is emmited by the `ERC20Trace` event to allow us to keep importing, we workaround this issue by overwriting the re-execution logs by the value found in the original receipt
marcospb19-cw
force-pushed
the
copy-gasLeft-from-original-transaction-receipt-on-import
branch
from
b6108e1 to
c563890
Compare
marcospb19-cw
deleted the
copy-gasLeft-from-original-transaction-receipt-on-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.