Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run on cloudwalk runners #803

Closed
wants to merge 1 commit into from
Closed

build: run on cloudwalk runners #803

wants to merge 1 commit into from

Conversation

dinhani-cw
Copy link
Contributor

No description provided.

@dinhani-cw dinhani-cw requested a review from a team as a code owner May 8, 2024 13:43
Copy link

github-actions bot commented May 8, 2024

PR Review 🔍

⏱️ Estimated effort to review [1-5]

2, because the changes are straightforward and consistent across multiple workflow files, involving only the modification of the runner type from 'ubuntu-latest' to 'cloudwalk-k8s-runner'.

🧪 Relevant tests

No

⚡ Possible issues

Compatibility Issue: Ensure that the 'cloudwalk-k8s-runner' is fully compatible with all the steps and actions used in the workflows, as it replaces 'ubuntu-latest'.

🔒 Security concerns

No

Code feedback:
relevant file.github/workflows/_setup-e2e.yml
suggestion      

Verify that the 'cloudwalk-k8s-runner' has all the necessary tools and permissions that were available in 'ubuntu-latest' to avoid runtime errors. [important]

relevant lineruns-on: cloudwalk-k8s-runner

relevant file.github/workflows/comment-tag-report.yml
suggestion      

Consider adding a fallback or a condition to switch back to 'ubuntu-latest' if 'cloudwalk-k8s-runner' fails to meet the requirements. [medium]

relevant lineruns-on: cloudwalk-k8s-runner

relevant file.github/workflows/docs-release.yml
suggestion      

Ensure that the new runner has the necessary environment setup for Rust and Cargo, as these tools are critical for the documentation build process. [important]

relevant lineruns-on: cloudwalk-k8s-runner

relevant file.github/workflows/e2e-contracts-postgres.yml
suggestion      

Test the 'cloudwalk-k8s-runner' specifically with the Postgres setup to ensure that the database interactions work as expected without any disruptions. [important]

relevant lineruns-on: cloudwalk-k8s-runner

Copy link

github-actions bot commented May 8, 2024

PR Code Suggestions ✨

CategorySuggestions                                                                                                                                                       
Bug
Change the environment variable to enable debug information in release builds.

Ensure that the environment variable CARGO_PROFILE_RELEASE_DEBUG is set to 1 instead of 0
to enable debug information in release builds, which is crucial for diagnosing issues in
production.

.github/workflows/e2e-contracts-postgres.yml [86]

-CARGO_PROFILE_RELEASE_DEBUG: 0
+CARGO_PROFILE_RELEASE_DEBUG: 1
 
Enhancement
Adjust log level to capture essential information.

Set RUST_LOG to info or debug instead of off to capture essential logging information,
which can be helpful for monitoring and troubleshooting.

.github/workflows/e2e-contracts-rocks.yml [88]

-RUST_LOG: off
+RUST_LOG: info
 
Add error handling steps to the documentation build process.

Consider adding a failure step to handle potential errors during the documentation build
process, enhancing the robustness of the CI pipeline.

.github/workflows/docs-release.yml [25]

 runs-on: cloudwalk-k8s-runner
+steps:
+  - name: Handle failure
+    if: failure()
+    run: echo "Documentation build failed."
 
Maintainability
Include debug symbols in release builds for better debugging.

Modify the CARGO_PROFILE_RELEASE_DEBUG setting to 1 to ensure that debug symbols are
included in the release builds, aiding in better debugging and profiling.

.github/workflows/e2e-contracts.yml [86]

-CARGO_PROFILE_RELEASE_DEBUG: 0
+CARGO_PROFILE_RELEASE_DEBUG: 1
 

@dinhani-cw
Copy link
Contributor Author

Just changing the runs-on attribute is not enough to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant