Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible buffer overflow in uclient.c:170 #5

Open
uklatt opened this issue Aug 1, 2018 · 2 comments
Open

Possible buffer overflow in uclient.c:170 #5

uklatt opened this issue Aug 1, 2018 · 2 comments

Comments

@uklatt
Copy link

uklatt commented Aug 1, 2018

[ 20%] Building C object CMakeFiles/cshark.dir/src/uclient.c.o
/opt/buildbot/slaves/lede-slave-tah/mips_24kc/build/sdk/build_dir/target-mips_24kc_musl/cshark-2015-11-24-e575ab3d35d75a6f70488001fcba45690ebe9b3e/src/uclient.c: In function 'cshark_uclient_init':
/opt/buildbot/slaves/lede-slave-tah/mips_24kc/build/sdk/build_dir/target-mips_24kc_musl/cshark-2015-11-24-e575ab3d35d75a6f70488001fcba45690ebe9b3e/src/uclient.c:170:50: error: '%s' directive output may be truncated writing up to 1023 bytes into a region of size 1007 [-Werror=format-truncation=]
   snprintf(extra_tags, BUFSIZ, "?additional_tags=%s", config.tags);
                                                  ^~   ~~~~~~
/opt/buildbot/slaves/lede-slave-tah/mips_24kc/build/sdk/build_dir/target-mips_24kc_musl/cshark-2015-11-24-e575ab3d35d75a6f70488001fcba45690ebe9b3e/src/uclient.c:170:3: note: 'snprintf' output between 18 and 1041 bytes into a destination of size 1024
   snprintf(extra_tags, BUFSIZ, "?additional_tags=%s", config.tags);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
CMakeFiles/cshark.dir/build.make:88: recipe for target 'CMakeFiles/cshark.dir/src/uclient.c.o' failed

I made a pull request...

Uwe

@uklatt uklatt closed this as completed Aug 9, 2018
@uklatt
Copy link
Author

uklatt commented Aug 9, 2018

Problem was solved with last commit.

@uklatt uklatt reopened this Aug 15, 2018
@uklatt
Copy link
Author

uklatt commented Aug 15, 2018

Hello please integrate the open pull request.
This will fix the compiling error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant