-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve prevent_unencrypted_uploads
documentation
#179
fix: improve prevent_unencrypted_uploads
documentation
#179
Conversation
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
/terratest |
@cloudposse/engineering please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @pazaan
@pazaan thank you for the PR. Please add The test is complaining that the description is missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
/terratest |
@pazaan could you please add one more change to
|
/terratest |
Thank you, @pazaan 👏 |
@cloudposse/approvers please review this as a code owner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what
Update documentation for the
prevent_unencrypted_uploads
variable to more clearly explain its behavior.why
references
prevent_unencrypted_uploads
is possibly poorly named #177notes
I also opened a PR on the CI job to fix this job error