Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve prevent_unencrypted_uploads documentation #179

Closed

Conversation

pazaan
Copy link
Contributor

@pazaan pazaan commented Jul 5, 2024

what

Update documentation for the prevent_unencrypted_uploads variable to more clearly explain its behavior.

why

references

notes

I also opened a PR on the CI job to fix this job error

@pazaan pazaan requested review from a team as code owners July 5, 2024 06:26
@pazaan pazaan requested review from Gowiem and gberenice July 5, 2024 06:26
@mergify mergify bot added triage Needs triage needs-cloudposse Needs Cloud Posse assistance labels Jul 5, 2024
Copy link

mergify bot commented Jul 5, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@gberenice gberenice added the documentation Improvements or additions to documentation label Jul 5, 2024
@gberenice
Copy link

/terratest

gberenice
gberenice previously approved these changes Jul 5, 2024
@mergify mergify bot removed the triage Needs triage label Jul 5, 2024
@gberenice gberenice removed the needs-cloudposse Needs Cloud Posse assistance label Jul 5, 2024
@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jul 5, 2024
@gberenice
Copy link

@cloudposse/engineering please review this PR.

@aknysh aknysh added the patch A minor, backward compatible change label Jul 18, 2024
aknysh
aknysh previously approved these changes Jul 18, 2024
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pazaan

@aknysh
Copy link
Member

aknysh commented Jul 18, 2024

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@pazaan pazaan dismissed stale reviews from gberenice and aknysh via c07d633 July 19, 2024 01:59
@pazaan pazaan requested a review from aknysh July 19, 2024 02:00
@gberenice
Copy link

/terratest

@gberenice
Copy link

@pazaan could you please add one more change to examples/complete/variables.tf to satisfy tflint:

  variables.tf:6:1: warning: variable "arn_format" is declared but not used ()

@gberenice
Copy link

/terratest

@gberenice
Copy link

Thank you, @pazaan 👏

@gberenice
Copy link

@cloudposse/approvers please review this as a code owner.

@Nuru Nuru self-requested a review July 22, 2024 06:40
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pazaan As I explained here, I believe you are wrong about the impact of the setting, and therefore I believe the updated description is still misleading and not appropriate.

@pazaan pazaan closed this Sep 20, 2024
@pazaan pazaan deleted the update-prevent_unencrypted_uploads-doco branch September 20, 2024 03:31
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable prevent_unencrypted_uploads is possibly poorly named
4 participants