Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove static logger #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove static logger #40

wants to merge 1 commit into from

Conversation

leonardoce
Copy link
Contributor

No description provided.

@leonardoce
chore: remove static logger
0d7ffcc 
Signed-off-by: Leonardo Cecchi <[email protected]>
@leonardoce leonardoce requested a review from a team as a code owner October 10, 2024 16:06
fcanovai
fcanovai reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@fcanovai fcanovai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require a huge refactoring on the CNPG project, and I'd avoid merging this before that refactoring is done.

I like the idea of forcing the logs to have a context, but this is too aggressive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcanovai fcanovai fcanovai left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonardoce @fcanovai