Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect PHPDoc @param object types #4

Open
1 of 5 tasks
magnusnordlander opened this issue Mar 3, 2023 · 1 comment
Open
1 of 5 tasks

Incorrect PHPDoc @param object types #4

magnusnordlander opened this issue Mar 3, 2023 · 1 comment

Comments

@magnusnordlander
Copy link

Bug report for Cloudinary PHP Transformation Builder SDK

Before proceeding, please update to the latest version and test if the issue persists

Describe the bug in a sentence or two.

Incorrect PHPDoc tag for Cloudinary\Transformation\TransformationResizeTrait::fill. The $gravity argument is documented as taking an instance of Cloudinary\Transformation\Gravity, but in fact expects an instance of Cloudinary\Transformation\GravityQualifier. Presumably this is a bigger issue than just this one argument, but this is where PHPStan complains for me, so I thought I'd start somewhere.

Issue Type (Can be multiple)

  • Build - Can’t install or import the SDK
  • Performance - Performance issues
  • Behaviour - Functions aren’t working as expected (such as generate URL)
  • Documentation - Inconsistency between the docs and behaviour
  • Other (Specify)
@wissam-khalili
Copy link

Hi @magnusnordlander ,

Thank you for your feedback.
I will check the issue internally and keep you posted on our findings.

Regards,
Wissam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants