Clone configuration in Url.clone()

cloudinary · Nov 5, 2018 · c447b5c · c447b5c
1 parent 1fe5dba
commit c447b5c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/cloudinary-core/src/main/java/com/cloudinary/Url.java b/cloudinary-core/src/main/java/com/cloudinary/Url.java
@@ -52,7 +52,7 @@ public Url(Cloudinary cloudinary) {
 
     public Url clone() {
         Url cloned = cloudinary.url();
-
+        cloned.config.update(config.asMap());
         cloned.fallbackContent = this.fallbackContent;
         cloned.format = this.format;
         cloned.posterSource = this.posterSource;

diff --git a/cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java b/cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java
@@ -3,6 +3,7 @@
 import com.cloudinary.Cloudinary;
 import com.cloudinary.ResponsiveBreakpoint;
 import com.cloudinary.Transformation;
+import com.cloudinary.Url;
 import com.cloudinary.transformation.*;
 import com.cloudinary.utils.ObjectUtils;
 import junitparams.JUnitParamsRunner;
@@ -1159,5 +1160,10 @@ public static Map<String, String> getUrlParameters(URI uri) throws UnsupportedEn
         return params;
     }
 
-
+    @Test
+    public void testUrlCloneConfig(){
+        // verify that secure (from url.config) is cloned as well:
+        Url url = cloudinary.url().cloudName("cloud").format("frmt").publicId("123").secure(true);
+        assertEquals("https://res.cloudinary.com/cloud/image/upload/123.frmt", url.clone().generate());
+    }
 }