me-18308: refactor to use page manager #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…sting-specs-to-use-page-manager
…-to-use-page-manager' into me-18308-refactor-existing-specs-to-use-page-manager
refael-m
approved these changes
Dec 8, 2024
tsi
added a commit
that referenced
this pull request
Dec 9, 2024
* chore: release-manual * chore: release-manual * fix: use videojs events & re-trigger to analytics package with custom… (#639) * fix: use videojs events & re-trigger to analytics package with custom events * fix: import / bump package * Update release-edge.yml * Update release-manual.yml * chore(edge): release 2.0.4-edge.0 (#656) * chore(edge): release 2.0.4-edge.0 * Update CHANGELOG.md --------- Co-authored-by: Tsachi Shlidor <[email protected]> * fix: remove polyfill (#665) * chore(edge): release 2.0.5-edge.0 (#666) * fix: separate edge/master changelogs (#663) * fix: separate edge/master changelogs Co-Authored-By: Tsachi Shlidor <[email protected]> Co-Authored-By: cloudinary-jenkins <[email protected]> * chore: update changelog-edge --------- Co-authored-by: cloudinary-jenkins <[email protected]> * fix: fetchLatestRelease * fix: fetchLatestRelease * fix: fetchLatestRelease * fix: fetchLatestRelease * chore(edge): release 2.0.5-edge.1 (#667) * chore(edge): release 2.0.5-edge.1 * Update CHANGELOG-edge.md --------- Co-authored-by: Tsachi Shlidor <[email protected]> * fix: security issue braces (#668) * ME-16623 - creating first VP automation test (#664) * vp test: initial first test * vp test: initial first test * update e2e tests * update e2e * update e2e * update e2e * added eslint to e2e * vp test: initial first test * vp test: initial first test * update validatePageErrors function * update workers number * vp test: initial first test * vp test: initial first test * vp test: change for to for each * vp test: change back to for and update number of workers * vp test: refactor based on review comments * vp test: change timout * vp test: change timout and add logs * vp test: comment out flaky test on CI * vp test: comment out flaky test on CI --------- Co-authored-by: refael-m <[email protected]> * fix: custom profile docs example (#673) * fix: chapters innerHTML to innerText (#671) * fix: remove braces override (#670) Co-authored-by: Tsachi Shlidor <[email protected]> * chore(edge): release 2.0.5-edge.2 (#669) * vp test: handle flaky tests (#674) * vp test: update number of workers * vp test: update number of workers to 4 * vp test: update workers back to 5 * test: decrease workers to 1 * vp test: update webserver URL * vp test: update webserver URL * vp test: increase number of workers to 6 * vp test: increase number of workers to 6 * vp test: increase number of workers to 5 * vp test: reduce number of workers to 4 * vp test: increase number of workers to 5 * vp test: temp commit * vp test: revert temp commit * vp test: comment out adaptive streaming as it is flaky --------- Co-authored-by: alexeykagansky <[email protected]> * vp test: adding workflow and action for CI (#675) * Edit workflow (#676) * fix workflow * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * Update update_master.yml * fix: profiles docs link (#683) * vp test: adding new test to handle ESM page + small refactoring (#684) * vp test: adding new test to handle ESM page + small refactoring * vp test: remove flaky adaptive streaming * vp test: remove skip from ESM profile page and skip adaptive streaming * feat: new 'player' method with support async loading & profiles (#678) * feat: new 'player' method with support async loading & profiles * feat: new 'player' method with support async loading & profiles * fix: review comments * fix: bump VP size * fix: allow for profile url value * fix: isRawUrl path * feat: custom data video analytics param (#687) * feat: custom data video analytics param * feat: custom data video analytics param * fix: update dependencies (#688) * chore: update dependencies * fix: sass deprecation warnings * fix: bundlewatch * fix: docs for profiles & analytics, analytics options (#689) * fix: docs for profiles & analytics, analytics options * fix: docs for profiles & analytics, analytics options * fix: docs for profiles & analytics, analytics options * fix: bump analytics package version * chore(edge): release 2.0.6-edge.0 (#685) * Publish playwright report to reports repo (#690) * update e2e github flow * update * update * update * update * update * update * update * update * update ssh * update * update * update * added e2e to separate workflow * update * update * update * update * removed if always() from push reports step * vp test: adding error message to ignore errors for ESM pages (#695) * feat: add url template for video player profiles (#696) * feat: add url template for video player profiles * feat: docs profile url * fix: default secure option for new method (#698) * fix: default secure option for new method * fix: docs raw url * chore(edge): release 2.1.1-edge.0 (#697) * feat: add internal analytics about new method & profiles (#699) * feat: add internal analytics about new method & profiles * chore(edge): release 2.1.1-edge.1 (#700) * fix: use cld player profiles package for default profiles (#701) * fix: use cld player profiles package for default profiles * chore(edge): release 2.1.1-edge.2 (#702) * Me 18059 esm tests over preview build (#727) * vp test: support esm test running on preview deploy * vp test: support esm test running on preview deploy increase timeout * vp test: support esm test running on preview deploy revert timeout * vp test: adding waitFor function for checking if preview URL is ready * vp test: adding waitFor function for checking if preview URL is ready * vp test: adding waitFor function for checking if preview URL is ready * vp test: modify changes * vp test: modify changes * vp test: modify waitForDeployPreviewUrl * vp test: modify waitForDeployPreviewUrl * vp test: modify changes * vp test: modify changes * vp test: remove beforeAll * vp test: modify waitForDeployPreviewUrl function * vp test: modify waitForDeployPreviewUrl function * vp test: modify waitForDeployPreviewUrl function * vp test: modify waitForDeployPreviewUrl function adding a print * vp test: modify changes * vp test: adding print to log + increasing timeout * vp test: revert timeout * vp test: adding timeout * vp test: adding test for is deploy URL ready * vp test: revert test * vp test: change assertion * vp test: change assertion * vp test: modify waitForDeployPreviewUrl * vp test: modify waitForDeployPreviewUrl assertion * vp test: adding beforeEach and modify waitForDeployPreviewUrl * vp test: modify waitForDeployPreviewUrl * vp test: adding logs for debugging * vp test: adding logs for debugging * vp test: adding logs for debugging * vp test: adding logs for debugging * vp test: adding logs for debugging * vp test: modify waitForDeployPreviewUrl and revert debugging prints * vp test: modify waitForDeployPreviewUrl * vp test: refactor based on review comments * vp test: remove console log print * fix: one event for internal analytics (#728) * fix: one event for internal analytics * chore(edge): release 2.1.2-edge.0 (#732) * ME-17952: test if video is playing on main page (#733) * vp test: test if video is playing on main page * vp test: rename playVideo to clickPlay * Me 17953 test video on ai highlights graph page (#734) * vp test: test if video is playing on highlight graph page * vp test: test if video is playing on highlight graph page * vp test: remove comment * vp test: refactor based on review. Adding getLinkByName function and support enum for example page names * vp test: refactor based on review adding page manager * vp test: modify test description (#735) * vp test: refactor to support ExampleLinkName enum (#736) * vp test: refactor to support ExampleLinkName enum * vp test: rename file * fix: source analytics (#738) * fix: source analytics * chore: cleanup * chore(edge): release 2.1.2-edge.1 (#739) * feat: allow transcript from url (#737) * feat: allow transcript url * chore: transcript analytics * chore: transcript analytics * chore(edge): release 2.1.2-edge.2 (#740) * feat: auto-fetch transcripts from language (#741) * feat: auto-fetch transcripts from language * chore: update tests * feat: auto-fetch transcripts from language * feat: auto-fetch transcripts from language * chore: esm examples * chore(edge): release 2.1.2-edge.3 (#742) * chore: examples * fix: videojs 8 deprecation warning for videojs.bind (#744) * feat: support srt subtitle format (#743) * feat: support srt subtitle format * chore: add example and usage monitoring * chore: esm examples * chore: esm example * chore: examples * feat: support srt subtitle format * chore(edge): release 2.1.2-edge.4 (#745) * fix: programatic text-tracks in Safari (#747) * fix: programatic text-tracks in Safari * chore: bundlewatch * fix: programatic text-tracks in Safari * chore(edge): release 2.1.2-edge.5 (#748) * me-18308: refactor to use page manager (#749) * vp test: refactor to use page manager * vp test: refactor to use page manager * vp test: remove comment --------- Co-authored-by: Tsachi Shlidor <[email protected]> Co-authored-by: jakub-roch <[email protected]> Co-authored-by: cloudinary-jenkins <[email protected]> Co-authored-by: ShayLevi <[email protected]> Co-authored-by: refael-m <[email protected]> Co-authored-by: alexeykagansky <[email protected]> Co-authored-by: refael-m <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task link:
https://cloudinary.atlassian.net/browse/ME-18308
Page Manager was created previously. This PR is to refactor and make sure all pages are using the page manager and modify the specs to use it correctly.