-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CldVideoPlayer fullscreen object-cover issue #433
Comments
hey @apetta can you share the code you're trying to use and an example of what you're trying to achieve? |
@colbyfayock Sure thing! Here's a repo with the issue You can see the issue on a desktop viewport. Thank you! |
thanks for the example, that was really helpful i think this is currently simply not supported natively. I'm currently wrapping the player with an aspect ratio'ed container in order to provide better responsiveness and id imagine that's certainly preventing this ability looking into the issue itself though, the video player uses videojs under the hood, and found some potential solutions here: videojs/video.js#3431 id be happy to rethink that and add this capability, but currently working on wrapping up a major release, so would need to be once im through with that: #407 that said, i think there are two options in the meantime:
along the lines of:
|
@colbyfayock Thanks for looking into this, glad to know I wan't missing something obvious. I think the Another blocker even if I found a hacky layout, is setting the |
yeah im thinking that because im not exposing anything that allows you to modify the video element that won't be possible yes please, can you create a new Issue for that one? |
hey @apetta did you find a solution? i'm having the same issue right now ! |
Hey, I think I just generated the URL and used a custom |
I'm having a challenge getting a full-screen video with object-cover to work with
CldVideoPlayer
in nextjs 14. I think the styles fromnext-cloudinary/dist/cld-video-player.css
may be causing an issue here. A regularvideo
element works as expected.The poster image correctly sizes itself, but the video refuses to fill the container.
This is on
"next-cloudinary": "~5.20.0"
The text was updated successfully, but these errors were encountered: