Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates responsive images #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

developer-diganta
Copy link
Contributor

@developer-diganta developer-diganta commented Jan 8, 2023

Description

The srcset for images from cloudinary is generated and the result is stored in urlsrcset.
However, I could not understand where to add this result to the image.

The added part to netlfiy.toml file looks something like this:

    [[plugins.inputs.sizes]]
    width = 400
    height = 300
    crop = "pad"

    [[plugins.inputs.sizes]]
    width = 260
    height = 200
    crop = "crop"
    gravity = "north"
    

So far, I have just tried it with sizes.

Issue Ticket Number

#22

Fixes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@netlify
Copy link

netlify bot commented Jan 8, 2023

Deploy Preview for netlify-plugin-cloudinary failed.

Name Link
🔨 Latest commit ef4090b
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-cloudinary/deploys/63ba7fe755bef70008548d98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant