Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update transformation types for Cloudinary Video Player #202

Open
colbyfayock opened this issue Sep 25, 2024 · 4 comments · May be fixed by #215
Open

[Feature] Update transformation types for Cloudinary Video Player #202

colbyfayock opened this issue Sep 25, 2024 · 4 comments · May be fixed by #215
Assignees

Comments

@colbyfayock
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe.

We should update the types for Cloudinary Video Player for the available options:

https://github.com/cloudinary/js-url-gen/blob/master/src/types/types.ts#L431

This is the API that's used in the underlaying Video Player, via:

https://github.com/cloudinary/cloudinary-video-player/blob/edge/src/plugins/cloudinary/common.js#L55

Describe the solution you'd like

Should be able to, for the most part, copy in all of the types from the above int othe types/cloudinary-video-player.ts file

https://github.com/cloudinary-community/cloudinary-util/blob/main/packages/types/src/types/cloudinary-video-player.ts

@nooras
Copy link
Contributor

nooras commented Oct 5, 2024

Hey @colbyfayock
i am interested in this task. Can u assign me ?
shall i copy full block of LegacyITransforamtionOptions ? if yes! My code changes are ready let me know if its correct ?

Doubt:
That particular block have used this type transformations.

import Transformation from "../backwards/transformation.js";

Where should i paste this file ?

@colbyfayock
Copy link
Collaborator Author

i think we may be able to import it directly from the dependency, but import it specifically as a type, so that the dependency doesnt impact the bundle size

import type Transformation from ...

@nooras
Copy link
Contributor

nooras commented Oct 7, 2024

@colbyfayock
Unable to import Transformation directly in cloudinary-video-player.ts
Able to import in url-loader!
What should i do? shall i add dependency in type folder ?

image

@colbyfayock
Copy link
Collaborator Author

yeah you can try adding the dependency, npm install @cloudinary/url-gen

nooras added a commit to nooras/cloudinary-util that referenced this issue Oct 9, 2024
@nooras nooras linked a pull request Oct 9, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants