-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Update transformation
types for Cloudinary Video Player
#202
Comments
Hey @colbyfayock Doubt:
Where should i paste this file ? |
i think we may be able to import it directly from the dependency, but import it specifically as a type, so that the dependency doesnt impact the bundle size
|
@colbyfayock |
yeah you can try adding the dependency, npm install |
Feature Request
Is your feature request related to a problem? Please describe.
We should update the types for Cloudinary Video Player for the available options:
https://github.com/cloudinary/js-url-gen/blob/master/src/types/types.ts#L431
This is the API that's used in the underlaying Video Player, via:
https://github.com/cloudinary/cloudinary-video-player/blob/edge/src/plugins/cloudinary/common.js#L55
Describe the solution you'd like
Should be able to, for the most part, copy in all of the types from the above int othe types/cloudinary-video-player.ts file
https://github.com/cloudinary-community/cloudinary-util/blob/main/packages/types/src/types/cloudinary-video-player.ts
The text was updated successfully, but these errors were encountered: